Comments on T10/14-180r2

Paul Suhler Paul.Suhler at hgst.com
Thu Oct 9 09:32:04 PDT 2014


Formatted message: <a href="http://www.t10.org/cgi-bin/ac.pl?t=r&f=r1410090_f.htm">HTML-formatted message</a>

Hi, Tim.
After the NVMe call today, I decided to check 14-180r2 against the NVMe 1.2
release candidate.  Here are some things I noticed.
6.1.13.14 Additional Element Status descriptor protocol-specific information
for NVMe
General question:  Why not include the specific field names in the NVME
Identify Controller Data Structure?  That would eliminate any ambiguity.
Page 17, third paragraph after table XX.4, apparent cut and paste error:
"The MODEL NUMBER field contains 40 bytes of left-aligned ASCII data
identifying the serial number for the NVMe subsystem, as reported in the
Identify Controller Data Structure (see NVMe) . A MODEL NUMBER field set to
all ASCII spaces indicates that the serial number for the device is not
reported."
"serial number" s/b "model number"
Page 17, table XX.3 - NVMe port descriptor:
I had to step away while this was being discussed, but will 12 bits of PCIe
physical slot number (or 16 bits, if expanded into the Reserved field in byte
7) be enough future-proofing?
Page 18, second paragraph (CONTROLLER ID field) is worded differently than,
e.g., the paragraphs for SERIAL NUMBER field or MODEL NUMBER field:
The CONTROLLER ID field indicates the NVM subsystem unique controller
identifier associated with the controller reported in the NVMe Identify
Controller response that is received through the port (see NVMe).
Should this be:
The CONTROLLER ID field contains two bytes of binary data identifying the NVM
subsystem unique controller identifier as reported in the Identify Controller
Data Structure (see NVMe).
Page 18, third paragraph:
The BUS NUMBER, PCIE FUNCTION NUMBER and DEVICE NUMBER fields contain the Bus
Number, PCIe Function Number and Device Number values for the first PCIe
device enumerated through the port in the NVMe disk attached to the slot (see
PCIe).
a)	Needs a comma before each "and"
b)	"disk" s/b "device"
c)	 "PCIe Function Number" does not appear in PCIe.  s/b "Function
Number"
d)	Should the Bus Number, Function Number, and Device Number references
indicate that they're in the Header Field (ARI and/or non-ARI, as
appropriate) ?
The BUS NUMBER, PCIE FUNCTION NUMBER, and DEVICE NUMBER fields contain the
Bus Number, Function Number, and Device Number values for the first PCIe
device enumerated through the port in the NVMe device attached to the slot
(see PCIe).
That's it for now.
Cheers,
Paul
Paul A. Suhler, PhD
Research Staff Member
HGST Research
paul.suhler at hgst.com
o: 949-476-1180 x275448
m: 949-241-6443
3001 Daimler St.
Santa Ana, CA 92705-5812
www.hgst.com<<a href="http://www.hgst.com/&gt">http://www.hgst.com/&gt;



More information about the T10 mailing list